[openstreetmap/openstreetmap-website] Move share sidebar to view (PR #6106)

Anton Khorev notifications at github.com
Mon Jun 16 09:44:19 UTC 2025


@AntonKhorev commented on this pull request.



> @@ -0,0 +1,10 @@
+class SharesController < ApplicationController
+  before_action :authorize_web
+  before_action :set_locale
+  authorize_resource :class => false
+
+  def show
+    expires_in 7.days, :public => true

This caching is what I wanted to remove from map key, once it's loaded on demand. There was an issue somewhere about map key being outdated, but I can't find it.

I don't see a good reason why this caching should be replicated instead.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6106#pullrequestreview-2931379972
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6106/review/2931379972 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250616/80dab0cd/attachment.htm>


More information about the rails-dev mailing list