[openstreetmap/openstreetmap-website] Make flash alerts dismissable (PR #6115)
Marwin Hochfelsner
notifications at github.com
Wed Jun 18 16:31:16 UTC 2025
@hlfan commented on this pull request.
> @@ -1,13 +1,17 @@
<% [[:error, :danger], [:warning, :warning], [:notice, :success]].each do |flash_type, bootstrap_type| %>
<% if flash[flash_type] %>
- <%= tag.div :class => "alert alert-#{bootstrap_type} row mx-0 mb-0 p-3 rounded-0 align-items-center",
+ <%= tag.div :class => "alert alert-dismissible alert-#{bootstrap_type} d-flex mb-0 p-3 gap-3 rounded-0 align-items-center",
+ "aria-label" => t("javascripts.close"),
Do you really want the aria label here or on the added button? Because it has another "Close".
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6115#pullrequestreview-2939955723
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6115/review/2939955723 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250618/ce1210e0/attachment.htm>
More information about the rails-dev
mailing list