[openstreetmap/openstreetmap-website] Language select modal dialog (PR #6119)
Anton Khorev
notifications at github.com
Fri Jun 20 12:19:42 UTC 2025
Implements the dialog from https://github.com/openstreetmap/openstreetmap-website/pull/6103#issuecomment-2985190722
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6119
-- Commit Summary --
* Allow to skip language update in basic preferences
* Redirect to referer from preferences
* Replace language select dropdown with modal dialog
* Test if language selector changes the language
* Change language instead of opening preferences when logged in
* Put language select button next to login button
* Add border language select button
* Put language select button next to burger in small layout
* Highlight currently selected language
* Arrange languages in multiple columns
* Shorten language names for selector
* Use small language notes where they don't matter much
-- File Changes --
M app/assets/javascripts/application.js (11)
M app/assets/javascripts/language_selector.js (16)
M app/assets/stylesheets/common.scss (22)
M app/controllers/preferences/basic_preferences_controller.rb (12)
M app/controllers/preferences/preferences_controller.rb (5)
M app/views/layouts/_header.html.erb (34)
R app/views/layouts/_select_language_button.html.erb (15)
A app/views/layouts/_select_language_list.html.erb (19)
M config/locales/en.yml (4)
M config/ui_languages.yml (14)
M test/controllers/preferences/basic_preferences_controller_test.rb (11)
A test/system/select_language_test.rb (49)
M test/system/site_test.rb (15)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/6119.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6119.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6119
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6119 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250620/9d8f8d67/attachment.htm>
More information about the rails-dev
mailing list