[openstreetmap/openstreetmap-website] Change incomplete report flash style from success to warning (PR #6126)
Anton Khorev
notifications at github.com
Mon Jun 23 13:31:36 UTC 2025
If you're reporting something and you managed to submit the form without filling out the required fields[^1], there's a message "Please provide the required details". The problem is that it's styled as a *success* message, as if the report was created, while actually it wasn't.
Before:

After:

[^1]: This shouldn't normally happen, you'll get a javascript error, as long as `required` html attributes are there.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6126
-- Commit Summary --
* Change incomplete report flash style from success to warning
-- File Changes --
M app/controllers/reports_controller.rb (2)
M test/controllers/reports_controller_test.rb (2)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/6126.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6126.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6126
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6126 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250623/9c405cbf/attachment.htm>
More information about the rails-dev
mailing list