[openstreetmap/openstreetmap-website] Refactor element version navigation tests (PR #6129)

[Tom Hughes]

@tomhughes commented on this pull request.

This is quite hard to remove just because in places it's deliberately removing tests for things that aren't actually removed yet but will be.

I don't see any major issues, though adding lots more system tests while technically the right thing to do is a bit worrying given how unreliable they seem to be.

> -    relation = create(:relation)
-    create(:relation_member, :relation => relation, :member => member)
-    sidebar_browse_check :node_path, member.id, "elements/show"
-    assert_select "a[href='#{relation_path relation}']", :count => 1
-  end
-
-  def test_show_deleted
-    node = create(:node, :visible => false)
-    sidebar_browse_check :node_path, node.id, "elements/show"
-    assert_select "h4", /^Version/ do
-      assert_select "a[href='#{old_node_path node, 1}']", :text => "1", :count => 1
-    end
-    assert_select "a[href='#{api_node_path node}']", :count => 0
-  end
-
-  def test_show_redacted

There doesn't seem to be any replacement for this test in the new system tests?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6129#pullrequestreview-2954717429
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6129/review/2954717429 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250624/0599e03b/attachment.htm>