[openstreetmap/openstreetmap-website] Refactor element version navigation tests (PR #6129)

Tom Hughes notifications at github.com
Tue Jun 24 18:30:46 UTC 2025


@tomhughes commented on this pull request.



> -    relation = create(:relation)
-    create(:relation_member, :relation => relation, :member => member)
-    sidebar_browse_check :node_path, member.id, "elements/show"
-    assert_select "a[href='#{relation_path relation}']", :count => 1
-  end
-
-  def test_show_deleted
-    node = create(:node, :visible => false)
-    sidebar_browse_check :node_path, node.id, "elements/show"
-    assert_select "h4", /^Version/ do
-      assert_select "a[href='#{old_node_path node, 1}']", :text => "1", :count => 1
-    end
-    assert_select "a[href='#{api_node_path node}']", :count => 0
-  end
-
-  def test_show_redacted

Yes you're right - it's quite misnamed because what it's really testing is that we don't show a location for a deleted node. The fact that the node has a prior redacted version isn't really relevant.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6129#discussion_r2164652411
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6129/review/2954910740 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250624/b34de214/attachment.htm>


More information about the rails-dev mailing list