[openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)
Anton Khorev
notifications at github.com
Sun Jun 29 01:56:22 UTC 2025
@AntonKhorev commented on this pull request.
> + .addClass("bg-body-tertiary");
+ labelLink
+ .closest("tr")
+ .after($("<tr>").append(cell));
+
+ if (data.icon) {
+ $("<img>")
+ .attr({ src: OSM.WIKIMEDIA_COMMONS_URL + "Special:FilePath/" + data.icon, height: "32" })
+ .addClass("float-start mb-2 me-2")
+ .appendTo(cell);
+ }
+ if (data.label) {
+ labelLink.clone()
+ .text(data.label)
+ .removeAttr("title")
+ .addClass("ms-1")
What is this margin for? If the goal is to make it stand out more compared to the text below, maybe `fw-medium` will work better?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2969057263
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6127/review/2969057263 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250628/350ee4b7/attachment.htm>
More information about the rails-dev
mailing list