[openstreetmap/openstreetmap-website] Integrate human-readable wikidata browser plugin (PR #6127)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> +        $(`<${data.label ? "sup" : "div"}>`)
+          .append($("<a>")
+            .attr("href", `https://${data.article.site.slice(0, -4)}.wikipedia.org/wiki/` + encodeURIComponent(data.article.title))
+            .text(data.label ? data.article.site : data.article.title)
+          )
+          .appendTo(cell);
+      }
+      if (data.description) {
+        $("<div>")
+          .text(data.description)
+          .addClass("small")
+          .appendTo(cell);
+      }
+    }
+
+    function initWikidataLinks() {

I'd check here if wikidata settings are defined and quit if they are not (empty string in `wikidata_url` maybe? or null, but then you'd also have to update `application_controller.rb` to skip nils).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6127#pullrequestreview-2971181765
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6127/review/2971181765 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250630/9ad9747a/attachment.htm>