[openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)

Anton Khorev notifications at github.com
Sat Mar 1 06:25:03 UTC 2025


@AntonKhorev commented on this pull request.



> @@ -80,6 +80,10 @@ OSM = {
 
     const hash = OSM.parseHash(location.hash);
 
+    const geoURI = Object.fromEntries(new URLSearchParams(
+      params.geouri?.replaceAll(/[?;]/g, "&")?.replaceAll(":", "=")

Are you sure you want `replaceAll(":", "=")`? Why do you need this replacement at all? What is going to happen on uris like `geo:323482,4306480;crs=EPSG:32618;u=20`?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2652302306
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5736/review/2652302306 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250228/42f01612/attachment.htm>


More information about the rails-dev mailing list