[openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
Máté Gyöngyösi
notifications at github.com
Tue Mar 4 09:14:05 UTC 2025
gy-mate left a comment (openstreetmap/openstreetmap-website#4789)
> Do we actually use that icon anywhere else at the moment?
The regex search `\Wicon link` on the whole codebase yields only this result. So I don't think so.
> It seems very bold to me
@tomhughes Shall I change https://github.com/gy-mate/openstreetmap-website/blob/2db5b718047d8dfb494fdc8fdd6012bf73f3f0ab/app/assets/images/sprite.svg#L30 to https://github.com/twbs/icons/blob/31673a7249bf9043f065aa5d263fc454946de3d8/icons/link.svg#L2-L3? I've looked it up and it seems that the MIT license (which they use) is compatible with GPLv2 (that this repo uses).
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#issuecomment-2696761142
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4789/c2696761142 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250304/e090243e/attachment.htm>
More information about the rails-dev
mailing list