[openstreetmap/openstreetmap-website] Add permalinks to changeset comments (PR #4789)
Anton Khorev
notifications at github.com
Wed Mar 5 09:14:06 UTC 2025
@AntonKhorev commented on this pull request.
> </small>
+ <a href="#c<%= comment.id %>">
+ <div class="icon link"></div>
+ </a>
Here's what I'd do:
```suggestion
<a href="#c<%= comment.id %>">
<svg width="16" height="16" fill="currentColor">
<path d="M4.715 6.542 3.343 7.914a3 3 0 1 0 4.243 4.243l1.828-1.829A3 3 0 0 0 8.586 5.5L8 6.086a1 1 0 0 0-.154.199 2 2 0 0 1 .861 3.337L6.88 11.45a2 2 0 1 1-2.83-2.83l.793-.792a4 4 0 0 1-.128-1.287z"/>
<path d="M6.586 4.672A3 3 0 0 0 7.414 9.5l.775-.776a2 2 0 0 1-.896-3.346L9.12 3.55a2 2 0 1 1 2.83 2.83l-.793.792c.112.42.155.855.128 1.287l1.372-1.372a3 3 0 1 0-4.243-4.243z"/>
</svg>
</a>
</small>
```
This is [the rotated icon](https://icons.getbootstrap.com/icons/link-45deg/). Yes it's going to be repeated as many times as there are comments, but that shouldn't be a big problem with compression. The advantage to inlining is that you can use `currentColor` instead of specifying the color.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4789#pullrequestreview-2660446072
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4789/review/2660446072 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250305/010149d9/attachment-0001.htm>
More information about the rails-dev
mailing list