[openstreetmap/openstreetmap-website] Remove controls sprite (PR #5752)

Marwin Hochfelsner notifications at github.com
Wed Mar 5 20:08:20 UTC 2025


Put the sprite icons into HTML with JS or Ruby.
Due to the nature of the leaflet locate plugin, that icon is done with a clip path.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5752

-- Commit Summary --

  * Unify active control button behaviour
  * Set fixthemap note link in template
  * Click links instead of icons in tests
  * Remove controls sprite

-- File Changes --

    D app/assets/images/sprite.svg (62)
    M app/assets/javascripts/fixthemap.js (6)
    M app/assets/javascripts/index/new_note.js (7)
    M app/assets/javascripts/index/query.js (13)
    M app/assets/javascripts/leaflet.locate.js (4)
    M app/assets/javascripts/leaflet.note.js (7)
    M app/assets/javascripts/leaflet.query.js (16)
    M app/assets/javascripts/leaflet.sidebar-pane.js (14)
    M app/assets/javascripts/leaflet.zoom.js (7)
    M app/assets/javascripts/user.js (4)
    M app/assets/stylesheets/common.scss (47)
    M app/views/site/fixthemap.html.erb (10)
    M app/views/site/welcome.html.erb (9)
    M test/system/index_test.rb (16)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5752.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5752.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5752
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5752 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250305/9b0335cd/attachment.htm>


More information about the rails-dev mailing list