[openstreetmap/openstreetmap-website] Write directions sidebar header using .erb template (PR #5754)

Anton Khorev notifications at github.com
Thu Mar 6 10:01:01 UTC 2025


#4900 v2
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5754

-- Commit Summary --

  * Separate setting/clearing listeners/values on directions endpoints
  * Move directions params init code to its own function
  * Move directions listeners init code to its own function
  * Write directions sidebar header using .erb template
  * Hide loader spinner when sidebar content is not displayed
  * Move directions title out of javascript i18n strings

-- File Changes --

    M app/assets/javascripts/index.js (4)
    M app/assets/javascripts/index/directions-endpoint.js (20)
    M app/assets/javascripts/index/directions.js (88)
    M app/assets/stylesheets/common.scss (5)
    M app/views/directions/search.html.erb (4)
    M app/views/layouts/map.html.erb (2)
    M config/locales/en.yml (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5754.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5754.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5754
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5754 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250306/a5bba78b/attachment.htm>


More information about the rails-dev mailing list