[openstreetmap/openstreetmap-website] Overhaul markers (PR #5764)
Marwin Hochfelsner
notifications at github.com
Fri Mar 7 11:04:57 UTC 2025
### Description
- Makes all[^1] markers SVGs with a similar structure. (addresses https://github.com/openstreetmap/openstreetmap-website/issues/850#issuecomment-2323133938)
- Adds marker variants for routing (addresses https://github.com/openstreetmap/openstreetmap-website/issues/929#issuecomment-78864019)
- Changes the note markers' ✔️, ❌ & ➕ to be drawn with a reused stroke instead of areas to reduce file size. It also renames them so all marker files start with _marker_.
- Continues to use marker-shadow.png from leaflet


[^1]: not the yellow marker as I don't have the colours for that one
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5764
-- Commit Summary --
* Name markers uniformly
* Overhaul markers
-- File Changes --
M app/assets/config/manifest.js (2)
D app/assets/images/closed_note_marker.svg (19)
D app/assets/images/marker-blue.png (0)
A app/assets/images/marker-blue.svg (20)
A app/assets/images/marker-from.svg (20)
D app/assets/images/marker-green.png (0)
A app/assets/images/marker-green.svg (20)
A app/assets/images/marker-note-closed.svg (20)
A app/assets/images/marker-note-new.svg (20)
A app/assets/images/marker-note-open.svg (20)
D app/assets/images/marker-red.png (0)
A app/assets/images/marker-red.svg (20)
A app/assets/images/marker-to.svg (20)
D app/assets/images/new_note_marker.svg (15)
D app/assets/images/open_note_marker.svg (19)
M app/assets/javascripts/embed.js.erb (4)
M app/assets/javascripts/index/directions.js (4)
M app/assets/javascripts/index/layers/notes.js (6)
M app/assets/javascripts/index/new_note.js (6)
M app/assets/javascripts/index/note.js (6)
M app/assets/javascripts/leaflet.map.js (4)
M app/assets/javascripts/osm.js.erb (18)
M app/views/dashboards/_contact.html.erb (2)
M app/views/dashboards/show.html.erb (2)
M app/views/layouts/_search.html.erb (4)
M app/views/notes/index.html.erb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5764.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5764.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5764
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5764 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250307/5405039f/attachment-0001.htm>
More information about the rails-dev
mailing list