[openstreetmap/openstreetmap-website] Sticky close button v2 (PR #5778)

Anton Khorev notifications at github.com
Sat Mar 8 16:11:04 UTC 2025


Previous version: #4825

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5778

-- Commit Summary --

  * Stop using sidebar header template in welcome banner
  * Move close button out of left sidebar content
  * Move close button out of right sidebar content
  * Create template for sidebar close controls
  * Make close buttons stick to the top of scrolled areas

-- File Changes --

    M app/assets/javascripts/index.js (2)
    M app/assets/javascripts/index/directions.js (4)
    M app/assets/javascripts/leaflet.sidebar-pane.js (15)
    M app/assets/javascripts/leaflet.sidebar.js (4)
    M app/assets/stylesheets/common.scss (1)
    M app/views/application/_sidebar_header.html.erb (7)
    A app/views/layouts/_sidebar_close.html.erb (14)
    M app/views/layouts/map.html.erb (10)
    M test/system/index_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5778.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5778.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5778
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5778 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250308/d08adfda/attachment.htm>


More information about the rails-dev mailing list