[openstreetmap/openstreetmap-website] Convert reportable_dates helper into heading helper (PR #5791)

Anton Khorev notifications at github.com
Tue Mar 11 11:43:00 UTC 2025


In #5787 I appended `created on %{datetime_created} ...` to the reported item in the heading. That can't be translated correctly because I'm constructing a sentence and "created"/"updated" need to agree with the subject in grammatical gender etc. The entire subheading needs to be translated together.

I'm also removing the double "Note":

Before:
![image](https://github.com/user-attachments/assets/95a30795-4eb9-49e4-bde5-9316d44e5dd7)

After:
![image](https://github.com/user-attachments/assets/d4f8a2d4-6318-4a5b-bb62-146015a32698)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5791

-- Commit Summary --

  * Convert reportable_dates helper into heading helper

-- File Changes --

    M app/helpers/issues_helper.rb (28)
    M app/views/issues/show.html.erb (6)
    M config/locales/en.yml (8)
    M test/helpers/issues_helper_test.rb (51)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5791.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5791.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5791
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5791 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250311/376fdc13/attachment.htm>


More information about the rails-dev mailing list