[openstreetmap/openstreetmap-website] Fixed the grammatical mistake regarding the hyphen in "sign-up" and "log-in" mentioned in Issue #5772 (PR #5792)
Ngoc Phuc Khang Nguyen
notifications at github.com
Tue Mar 11 14:05:35 UTC 2025
### Description
<!--Describe your changes in detail. If you have made changes to the UI, include screenshots. If your PR addresses a Github issue, please link to it.-->
I've sent up this change again as I messed up the Git flow for my last PR. Hopefully this will not need any further changes!
This Pull Request is to tackle the grammatical mistake mentioned in Issue #5772. In particular, the use of "sign-in" and "log-in" as a noun in this context is incorrect, as it is inconsistent with the other verbs within the permission list.
Fixes:
- "Sign-in" has been changed to "sign in" (without the hyphen).
- "Log-in" has been changed to "log in" (without the hyphen).
Required citations, credited to @maro-21 in the comment of the original issue, are as follows:
- https://www.oxfordlearnersdictionaries.com/definition/english/sign-in?q=sign-in
- https://en.wiktionary.org/wiki/sign-in
- https://www.dictionary.com/browse/sign-in
- https://www.oed.com/dictionary/sign-in_adj?tl=true
Thank you to those who have offered me tips to clean up my Git flow in the last PR!
### How has this been tested?
<!--Explain the steps you took to test your code.-->
Since this is a grammatical fix for a text, testing is not required.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5792
-- Commit Summary --
* Fixed the grammatical mistake regarding the hyphen in sign-up and log-in mentioned in Issue #5772
-- File Changes --
M config/locales/en.yml (6)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5792.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5792.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5792
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5792 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250311/b877276b/attachment.htm>
More information about the rails-dev
mailing list