[openstreetmap/openstreetmap-website] Add UserActivities module for structured user activity history (PR #5761)

Tom Hughes notifications at github.com
Tue Mar 11 20:47:24 UTC 2025


tomhughes left a comment (openstreetmap/openstreetmap-website#5761)

Did you try doing this via normal ActiveModel queries before resorting to raw SQL queries?

I certainly don't like the idea of interpolating arguments into the queries - the fact that you called the argument `quoted_user_id` immediately hints at the risks of doing so. Is it not possible to use bound parameters with these queries?

What analysis have you done of the execution plan(s) and the likely performance? Is everything using indexes or are there things which are doing table scans?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5761#issuecomment-2715668476
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5761/c2715668476 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250311/40e91a83/attachment-0001.htm>


More information about the rails-dev mailing list