[openstreetmap/openstreetmap-website] Add profile location (PR #5302)

David Tsiklauri notifications at github.com
Fri Mar 14 12:32:16 UTC 2025


@nertc commented on this pull request.



> +        if (updateLocationName) {
+          if (locationInput.checkLocation) {
+            updateHomeLocation(false, savedLat, savedLon, updateHomeLocation);
+          } else {
+            updateHomeLocation();
+          }
+        }

It shouldn't throw anything, but it should only be called if `L.latLng` doesn't fail. I can move it out from the `try` block, but it will add additional checks of `isNaN(lat)` and `isNaN(lon)`. Do you think it should be moved out?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#discussion_r1995469884
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5302/review/2685369249 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250314/9daaf0f4/attachment.htm>


More information about the rails-dev mailing list