[openstreetmap/openstreetmap-website] Add PWA geo protocol handler (PR #5736)

Anton Khorev notifications at github.com
Tue Mar 18 12:28:45 UTC 2025


@AntonKhorev commented on this pull request.



>            mapParams = {};
 
+    [geoURI.coordstring, ...geoURI.params] = geoURI.pathname.split(";");
+    geoURI.params = Object.fromEntries([...geoURI.searchParams, ...geoURI.params.map(p => p.split("=").map(decodeURIComponent))]);

Why would you go through this extra effort of merging url and geo parameters? How about urls like `geo:59.95121,30.37522;z=ignore?z=15`?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5736#pullrequestreview-2694339212
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5736/review/2694339212 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250318/75c86ebd/attachment.htm>


More information about the rails-dev mailing list