[openstreetmap/openstreetmap-website] Fix "undefined" comment when hiding resolved notes (PR #5842)

Anton Khorev notifications at github.com
Tue Mar 25 00:27:34 UTC 2025


There's no comment textarea on resolved note pages, but pressing *Hide* if you're a moderator still tries to read a value and submit it as a comment.

![image](https://github.com/user-attachments/assets/5d91489d-977e-4e58-a6e5-dd889cb4a6d5)

With this PR the value is read only if the textarea is present.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5842

-- Commit Summary --

  * Fix "undefined" comment when hiding resolved notes

-- File Changes --

    M app/assets/javascripts/index/note.js (7)
    M test/system/resolve_note_test.rb (1)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5842.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5842.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5842
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5842 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250324/2f1b5701/attachment.htm>


More information about the rails-dev mailing list