[openstreetmap/openstreetmap-website] Add dir="auto" to Markdown content for bidi (PR #5840)
Anton Khorev
notifications at github.com
Thu Mar 27 02:02:48 UTC 2025
@AntonKhorev commented on this pull request.
> + "dl",
+ # "dd", "dt", # child - since it's similar to a list, it has the same behavior as a list
+
+ "math" # don't know how this ends up, but dir="auto" is probably correct
+ ].each do |name|
+ define_method :"convert_#{name}" do |el, indent|
+ attr_bak = el.attr.dup # can't avoid mutating the attr hash, so make a backup
+ el.attr["dir"] = "auto" unless el.attr.key?("dir") # if by some miracle dir is already defined, don't override it
+ ret = super(el, indent)
+ el.attr.replace(attr_bak) # restore backup
+ ret
+ end
+ end
+
+ # only add dir="auto" to bare links
+ def convert_a(el, indent)
Do we need to set `dir` on inline elements too?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5840#pullrequestreview-2719178841
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5840/review/2719178841 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250326/fc81a30c/attachment.htm>
More information about the rails-dev
mailing list