[openstreetmap/openstreetmap-website] Search and latlon/nominatim query resources (PR #5868)

Anton Khorev notifications at github.com
Mon Mar 31 16:21:07 UTC 2025


@AntonKhorev commented on this pull request.



> +    const params = new URLSearchParams;
+    for (const paramName of ["query", "zoom", "minlon", "minlat", "maxlon", "maxlat"]) {
+      const paramValue = this.elements[paramName].value;
+      if (paramValue) {
+        params.set(paramName, paramValue);
+      }
+    }
+    const search = params.get("query") ? `/search?${params}` : "/";

> Do you really want to expose all these parameters in the URL?

Yes. Search results depend on them. If you don't agree, why put anything in the URL? Why should `query` be in the URL?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5868#discussion_r2021354838
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5868/review/2729837595 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250331/17077a91/attachment.htm>


More information about the rails-dev mailing list