[openstreetmap/openstreetmap-website] Move dashboard-specific javascript to dashboard.js (PR #5972)
Anton Khorev
notifications at github.com
Thu May 1 05:42:41 UTC 2025
Fixes #5971.
`user.js` does too many different things. It's better to take it apart and have smaller scripts included from all of the pages that currently include it.
This PR takes out dashboard-specific code from `user.js` and puth it into `dashboard.js`. This code doesn't include OSM.HomeLocationNameGeocoder which would fail on dashboard pages.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5972
-- Commit Summary --
* Move dashboard-specific javascript to dashboard.js
-- File Changes --
A app/assets/javascripts/dashboard.js (33)
M app/assets/javascripts/user.js (134)
M app/views/dashboards/show.html.erb (2)
M app/views/profiles/edit.html.erb (2)
M test/system/dashboard_test.rb (21)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5972.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5972.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5972
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5972 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250430/babf0e74/attachment.htm>
More information about the rails-dev
mailing list