[openstreetmap/openstreetmap-website] Clean OSM.formatHash calls (PR #5887)

Tom Hughes notifications at github.com
Tue May 6 18:48:29 UTC 2025


@tomhughes commented on this pull request.



> @@ -23,6 +23,12 @@ def result_to_html(result)
     safe_join(html)
   end
 
+  def map_hash(params)
+    return "" unless params[:lat].present? && params[:lon].present?
+
+    "#map=#{params[:zoom].to_i || 17}/#{params[:lat].to_f}/#{params[:lon].to_f}"

I just tried removing them and I couldn't get brakeman to complain... What exactly did it say?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5887#discussion_r2076064428
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5887/review/2819296143 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250506/8030e27c/attachment.htm>


More information about the rails-dev mailing list