[openstreetmap/openstreetmap-website] Move `gravatar_enable` method to User model (PR #5988)

Andy Allan notifications at github.com
Wed May 7 16:52:23 UTC 2025


gravitystorm left a comment (openstreetmap/openstreetmap-website#5988)

> You can just bump that limit - anything in `.rubocop_todo.yml` is just there to allow things that we haven't got around to doing anything yet and for those metrics ones at least it's not at all clear what if anything we even want to do.

Well.... they are there in order to discourage the situation from getting even worse. In many circumstances it's pragmatic to bump them up a bit (e.g. adding one more line to a 250-line class) but if we keep hitting these limits or if we blow past them in one PR, it's an indication that we should be refactoring.

For the metrics, I tend to find that the rubocop defaults are too small, our current values are way too large, and we could agree on a custom limit somewhere between the two (with a bit of refactoring for the worst offending files).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5988#issuecomment-2859302530
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5988/c2859302530 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250507/44e3daa7/attachment.htm>


More information about the rails-dev mailing list