[openstreetmap/openstreetmap-website] Add social profile links (PR #5439)
David Tsiklauri
notifications at github.com
Thu May 15 08:04:22 UTC 2025
nertc left a comment (openstreetmap/openstreetmap-website#5439)
PR was updated. `master` was merged. All conflicts were resolved.
PR was changed according to the suggestions.
Only RuboCop error is about the length of the `User` class (this PR added only 2 necessary lines to it). I can change `Metrics/ClassLength` to 623 from 621, but I think it either should be changed to some meaningful value in the separate PR (it shouldn't be changed every time `User` class is modified) or removed completely.
Feel free to suggest further changes related both to the code and RuboCop.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2882941316
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5439/c2882941316 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250515/8e8c998b/attachment.htm>
More information about the rails-dev
mailing list