[openstreetmap/openstreetmap-website] Implement JSON support for the changeset download API (PR #5973)

[mmd]

mmd-osm left a comment (openstreetmap/openstreetmap-website#5973)

Thank you for your feedback, in particular for the interesting example about the create action.

> I didn't see anyone respond above to @joto's point

I think I sort of addressed this one:  _I agree that the action attribute doesn't add much value, the information is anyway available in version and visible attributes. I guess there are historical reasons which I'm not familiar with in detail._

When designing the format from scratch again, there's a high probability that we might simply skip it. It seems there were good reasons to introduce it for the XML format back in the days... zerebubuth might know?

By the way, I'm assuming that even in case we wouldn't use an action attribute, the data is still processed top to bottom, meaning that you can't create a new way, and refer to new nodes that are appearing further down in the file.

> This is nice especially in strongly typed languages: if you have a type definition for an Element as returned by the OSM API, you can reuse that definition when fetching data from any of these endpoints.

Right, it seems we all agree that  a common definition of an element has some benefits, and that we don't want to taint it with unrelated properties, such as "if-unused".

> I'm ignoring the if-unused attribute used for uploading in these examples for simplicity

The question now is, how would you handle such additional attributes in case of an upload? My goal was to keep upload and download somehow similar enough that we don't end up with entirely different structures.

The other goal I had in mind was to keep XML and JSON format similar enough, that both can cover the same use cases, and they don't look totally different (which could result in a major maintenance burden in the future).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5973#issuecomment-2885019998
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5973/c2885019998 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250515/44d3d455/attachment-0001.htm>