[openstreetmap/openstreetmap-website] "Scroll to changeset" context menu item (PR #6059)

Tom Hughes notifications at github.com
Tue May 27 17:43:28 UTC 2025


@tomhughes commented on this pull request.



> @@ -112,7 +116,10 @@ OSM.History = function (map) {
 
   function toggleChangesetHighlight(id, state) {
     changesetsLayer.toggleChangesetHighlight(id, state);
-    $("#changeset_" + id).toggleClass("selected", state);
+    $("#sidebar_content .changesets ol li").removeClass("selected");
+    if (state) {
+      $("#changeset_" + id).addClass("selected");
+    }

Do we need a similar change inside the `toggleChangesetHighlight` call on the layer or is there something that stops that getting "stuck" in the same way?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6059#pullrequestreview-2871993509
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6059/review/2871993509 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250527/95c6c8ff/attachment.htm>


More information about the rails-dev mailing list