[openstreetmap/openstreetmap-website] Always use button elements for Remove social link buttons (PR #6062)
Anton Khorev
notifications at github.com
Wed May 28 16:09:59 UTC 2025
Fixes https://github.com/openstreetmap/openstreetmap-website/pull/5439#issuecomment-2904227124
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/6062
-- Commit Summary --
* Remove unnecessary event.preventDefault() from "Add Social Link"
* Remove unused ids from social link inputs
* Add social link controls using html template
* Add placeholders/titles to social link controls
* Make remove social link buttons always actually buttons
-- File Changes --
M app/assets/javascripts/user.js (51)
M app/views/profiles/edit.html.erb (10)
M config/locales/en.yml (5)
A test/system/user_social_links_test.rb (121)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/6062.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6062.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6062
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6062 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250528/18464283/attachment.htm>
More information about the rails-dev
mailing list