[openstreetmap/openstreetmap-website] Move html from javascript to views (PR #6063)

Marwin Hochfelsner notifications at github.com
Thu May 29 14:27:17 UTC 2025


Closes #5616 as a partial spiritual successor of #4335
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/6063

-- Commit Summary --

  * Write layer sidebar in erb template
  * Write share sidebar in erb template
  * Move layer sidebar translations
  * Move share sidebar translations
  * Put key content class in erb and load content only once
  * Add loadContent function to sidebarPane
  * Make event handler logic more terse

-- File Changes --

    M app/abilities/ability.rb (2)
    M app/assets/javascripts/leaflet.key.js (21)
    M app/assets/javascripts/leaflet.layers.js (118)
    M app/assets/javascripts/leaflet.share.js (259)
    M app/assets/javascripts/leaflet.sidebar-pane.js (6)
    A app/controllers/layers_controller.rb (10)
    A app/controllers/shares_controller.rb (10)
    A app/views/layers/show.html.erb (32)
    M app/views/map_keys/show.html.erb (2)
    A app/views/shares/show.html.erb (85)
    M config/locales/en.yml (41)
    M config/routes.rb (2)
    M lib/map_layers.rb (5)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/6063.patch
https://github.com/openstreetmap/openstreetmap-website/pull/6063.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6063
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6063 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250529/546e70f8/attachment.htm>


More information about the rails-dev mailing list