Re: [openstreetmap/openstreetmap-website] Migrate new vector layers from maplibre-gl-leaflet to “unwrapped” maplibre-gl-js (Issue #6234)

[Frank Elsinga]

CommanderStorm left a comment (openstreetmap/openstreetmap-website#6234)

I did a bit of tinkering about half a month back.
The main problem that I stumbled upon is that keeping this reviewable is kind of a struggle.
Doing this in one shot will shurely not be acceptable due to PR size.

Doing the necessary changes I noticed how many tiny corners there are and that replacing this would be sure to break at least one of them.
-> To keep risk Manageable for first OHM, second OSM some feature flag system (be it compile or runtime) would likely be needed to keep risk down and "the build green".

That is something where my ruby knowlege failed me.
Is there a PR I can look at for feature flags?

I think such a migration would defintively need to be behind a feature flag, given that it changes most of the map related code (for example because leaflet and maplibre do lat/lng vs lng/lat, subtle to miss 😆).

I am not super confident that I can make that part work tbh, ruby is not taught at uni and it is kind of weird.
Any pointers (or pair-programming) appreciated.

Also I had to hack parts of the ruby environment (f.ex. `config.assets.debug` in `config/environments/development.rb`) together to get the frontend symbols to be unmangled, not sure if there is a guide how to do this properly or if this is a.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/6234#issuecomment-3482220992
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/6234/3482220992 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251103/c3796a3f/attachment-0001.htm>