[openstreetmap/openstreetmap-website] feat: add social links and company to user api endpoint (PR #6452)
Tom Hughes
notifications at github.com
Mon Nov 10 20:26:37 UTC 2025
@tomhughes approved this pull request.
This looks good to me now, thanks.
> @@ -487,6 +502,26 @@ def check_xml_details(user, include_private, include_email)
def check_json_details(js, user, include_private, include_email)
assert_equal user.id, js["user"]["id"]
assert_equal user.description, js["user"]["description"]
+ if user.company
+ assert_equal user.company, js["user"]["company"]
+ else
+ assert_nil js["user"]["company"]
+ end
This should probably have been a separate commit, as it's fixing an existing issue in the test rather than being anything to do with the main purpose of this PR but let's not worry about it this time.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6452#pullrequestreview-3445012972
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6452/review/3445012972 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251110/935043cd/attachment.htm>
More information about the rails-dev
mailing list