[openstreetmap/openstreetmap-website] Resolve any open issues for a user when they are suspended (PR #6532)
Pablo Brasero
notifications at github.com
Tue Nov 18 12:20:55 UTC 2025
@pablobm commented on this pull request.
Looks good to me 👍 The only thing is the failing test, which is a pre-existing one that assumed that issues would stay unresolved after soft-destroying the user. I'm not sure the test makes sense any more? I think we can delete it altogether.
> @@ -66,7 +66,7 @@ Metrics/BlockNesting:
# Offense count: 26
# Configuration parameters: CountComments, CountAsOne.
Metrics/ClassLength:
- Max: 340
+ Max: 350
Tangentially to this PR: should we have this rule at all? It's the second change to this limit this month.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6532#pullrequestreview-3477516824
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6532/review/3477516824 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251118/2ad95cc9/attachment.htm>
More information about the rails-dev
mailing list