[openstreetmap/openstreetmap-website] Show tag changes in object history view (PR #6448)

[Waldir Pimenta]

waldyrious left a comment (openstreetmap/openstreetmap-website#6448)

> If the only concern is about screen reader behavior, then we could wrap the old value in `<del>` and the new value in `<ins>` and use CSS to eliminate any styling of both tags in this table.

I do agree that using the semantic tags with the usual CSS striped out would be desirable, since their meaning would be conveyed directly in screen readers, and by the colors (as progressive enhancement) for those with normal vision.

> Otherwise, I would view the suggestion for strikethrough as an alternative to the ± indicators, because if we do both then we’re starting to really overengineer the table with four visual differences between old and new.

I'd be inclined to share that view, but I'd like someone who's actually affected by color issues to comment on whether this is an acceptable solution. I mean, if we do hide the visual signals of `<ins>` and `<del>` in normal rendering, then we'd be leaving them with nothing but color to distinguish the values. We could assume that people who are affected by red/green styling would be likely to have custom user stylesheets or browser extensions to enhance color-only encoding of diffs, since that's a pretty common pattern; but I wouldn't want to take that decision (to deem color-only distinction sufficient in non-screen-reader contexts) on their behalf.

By the way, you raised a good point about e.g. printing the page — I'd suggest that matching rules be set up in [`print.scss`](https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/stylesheets/print.scss) to either restore the strikethrough styling (and possibly also underline, though maybe using an alternative CSS property like `border-bottom` to shift it downwards from the text baseline), or use pseudo-elements to prepend `+` and `-` indicators, when color is absent.

Anyway, we're pretty much veering towards bikeshedding now, so just to be clear, I'd be pretty happy with something like [this](https://github.com/openstreetmap/openstreetmap-website/pull/6448#issuecomment-3489346156) (with grey for unchganged values, as shown [here](https://github.com/openstreetmap/openstreetmap-website/pull/6448#issuecomment-3516849705)), as long as the changed values are wrapped in `<ins>`/`<del>` (regardless of their visibility).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6448#issuecomment-3564636673
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6448/c3564636673 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251121/64bc245f/attachment.htm>