[openstreetmap/openstreetmap-website] include iD as npm package (PR #6565)

[Martin Raifer]

@tyrasd commented on this pull request.



> @@ -22,7 +22,7 @@ document.addEventListener("DOMContentLoaded", function () {
 
     const id = idContext
       .embed(true)
-      .assetPath("iD/")
+      .assetPath("@openstreetmap/id/dist/")

That's odd. For me it only works as expected if I omit the `assets/` part here. AFAICT, this path needs to match the keys of the dictionary provided in `data-asset-map` (see screenshot below), which comes from the `asset_helper.rb` via `id.html.erb`. That one does have the assets listed without the `assets/` "prefix". :thinking: 

<img width="884" height="429" alt="image" src="https://github.com/user-attachments/assets/735fb47f-24ce-4e80-af5b-95a4604a34ba" />

If I use `.assetPath("assets/…`, iD still appears to run fine, but it will load the un-hashed assets (e.g. `http://127.0.0.1:3000/assets/@openstreetmap/id/dist/img/pattern/farmland.png` instead of `http://127.0.0.1:3000/assets/@openstreetmap/id/dist/img/pattern/farmland-a59cbecf2b7bb338812ee0b4e25dbf79183ac809f5818451850922142121c3d9.png`), which is not what we want, is it?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6565#discussion_r2564992351
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6565/review/3510948012 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251126/1bbe83e7/attachment-0001.htm>