[openstreetmap/openstreetmap-website] Migrate the dashboard entry page from leaflet to maplibre (PR #6504)

[Frank Elsinga]

CommanderStorm left a comment (openstreetmap/openstreetmap-website#6504)

> Personally I'd suggest removing the 1 pixel border between controls in a group so the the zoom in/out don't have a gap between them like the current map but I'm open to argument on that.

<details><summary>very simple to do (click to open)</summary>
<p>

```diff
diff --git i/app/assets/stylesheets/maplibre-gl-all.scss w/app/assets/stylesheets/maplibre-gl-all.scss
index c1426ef5e..3d10304aa 100644
--- i/app/assets/stylesheets/maplibre-gl-all.scss
+++ w/app/assets/stylesheets/maplibre-gl-all.scss
@@ -42,6 +42,10 @@
   background-color: white;
 }
 
+.maplibregl-ctrl-group button+button {
+  border-top: 0;
+}
+
 .maplibregl-ctrl button.maplibregl-ctrl-zoom-in .maplibregl-ctrl-icon {
   mask-image: image-url("map-controls/zoomin.svg");
 }
```

</p>
</details> 

Same as the choice of icon for the markers though this did not seem like a concious decision.
I think following the general trend and having buttons be a bit separated makes sense, but if you want I can dd the 4 lines.

I think it makes is simpler for people hard of seeing to differentiate buttons, but then I have 10/10 vision, so don't actually know what it is like.

> could we tone down the colour of the marker a bit? To get it a bit closer to the current one - it's not so much that I want it to be identical but the new one is very bright and a bit in your face?

Obviously, I could make the marker look the same way leaflet defaults.

Thing is: Do you actually want this?
For this feature, being obvious where something is locaed is kind of the point. In the end we don't want to hide this information.
(More contrast is also more accessible, not a big problem here though 😉)

| default maplibre | default leaflet |
|--|--|
| <img width="177" height="160" alt="image" src="https://github.com/user-attachments/assets/c9c10e53-d31b-4be5-b411-b473c49d17f1" /> | <img width="246" height="289" alt="image" src="https://github.com/user-attachments/assets/e821186b-9a76-4ae4-a302-e18055d5f53c" /> |

> Whether to put the geolocate control in the same group (if that's even possible?) is a more interesting question - it looks OK separate here but it might become more of an issue when we get to the main page where there are more controls?

It is *possible* to build a custom combined control, but that means more code, and given the feedback on keeping this PR minimal, I’m *guessing* that’s not preferred.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6504#issuecomment-3592568838
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6504/c3592568838 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251130/c4687ff9/attachment-0001.htm>