[openstreetmap/openstreetmap-website] Bootstrap contextmenu (PR #6410)

Tom Hughes notifications at github.com
Mon Oct 13 16:24:09 UTC 2025


@tomhughes commented on this pull request.

As I said before I think the structure of the commits here is wrong - rather than removing the old assets and commenting out the code in the first commit and then rewriting things and re-enabling the code in the second I would reverse things and have the first commit rework the code and the the second one clean up the now unused assets, style rules etc.

Long term it would be nice to see if we could generate the HTML on the server side and just attach event handlers in the client but I think we can tackle that separately.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6410#pullrequestreview-3332267312
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6410/review/3332267312 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251013/e6dbe668/attachment-0001.htm>


More information about the rails-dev mailing list