[openstreetmap/openstreetmap-website] feat: add social links and company to user api endpoint (PR #6452)

Moritz Stückler notifications at github.com
Mon Oct 20 16:21:30 UTC 2025


pReya left a comment (openstreetmap/openstreetmap-website#6452)

> This should be tested in `test/controllers/api/users_controller_test.rb` by extending `check_xml_details` and `check_json_details` and adding appropriate attributes to at least some of the users created by the test methods.
> 
> There's also a lint warning that needs resolving.

Thanks for the feedback and the hint regarding the tests. I tried to fix it, to the best of my ability. However, I'm not a Ruby programmer, so be gentle with me, please.

Full Disclosure: I've used AI/LLM Support for these changes (as much as I hate LLMs, for these kind of use cases I find them rather useful), as my Ruby knowledge is very very limited.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6452#issuecomment-3422804503
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6452/c3422804503 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251020/81d224b3/attachment.htm>


More information about the rails-dev mailing list