[openstreetmap/openstreetmap-website] Modified hdyc regex to accept spaces and percent-encoded spaces (PR #6468)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -31,7 +31,7 @@ class SocialLink < ApplicationRecord
     :flickr => %r{\Ahttps?://(?:www\.)?flickr\.com/people/([a-zA-Z0-9 at ._-]+)},
     :github => %r{\Ahttps?://(?:www\.)?github\.com/([a-zA-Z0-9_-]+)},
     :gitlab => %r{\Ahttps?://(?:www\.)?gitlab\.com/([a-zA-Z0-9_-]+)},
-    :hdyc => %r{\Ahttps?://(?:www\.)?hdyc\.neis-one\.org/\?([a-zA-Z0-9_-]+)},
+    :hdyc => %r{\Ahttps?://(?:www\.)?hdyc\.neis-one\.org/\?([a-zA-Z0-9\s%20_-]+)},

You don't need to add `20` there as that's a character class so it's matching each character individually and digits are already allowed.

I'm not really keen to handling escaping like this anyway - it would probably be better to canonicalise the URLs before matching them so we don't have to handle both escaped and unescaped versions in the regular expressions.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6468#pullrequestreview-3371690687
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6468/review/3371690687 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251023/721e6b99/attachment-0001.htm>