[openstreetmap/openstreetmap-website] Modified hdyc regex to accept spaces and percent-encoded spaces (PR #6468)

Tom Hughes notifications at github.com
Sun Oct 26 08:20:01 UTC 2025


@tomhughes commented on this pull request.



> @@ -31,7 +31,7 @@ class SocialLink < ApplicationRecord
     :flickr => %r{\Ahttps?://(?:www\.)?flickr\.com/people/([a-zA-Z0-9 at ._-]+)},
     :github => %r{\Ahttps?://(?:www\.)?github\.com/([a-zA-Z0-9_-]+)},
     :gitlab => %r{\Ahttps?://(?:www\.)?gitlab\.com/([a-zA-Z0-9_-]+)},
-    :hdyc => %r{\Ahttps?://(?:www\.)?hdyc\.neis-one\.org/\?([a-zA-Z0-9_-]+)},
+    :hdyc => %r{\Ahttps?://(?:www\.)?hdyc\.neis-one\.org/\?([a-zA-Z0-9\s%20_-]+)},

Well they don't actually break anything but they also don't really match % escape sequence and it definitely has redundant duplicate characters in the character class.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6468#discussion_r2463305817
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6468/review/3380526375 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251026/e0a06caa/attachment-0001.htm>


More information about the rails-dev mailing list