[openstreetmap/openstreetmap-website] Modified hdyc regex to accept spaces and percent-encoded spaces (PR #6468)
Paul Norman
notifications at github.com
Sun Oct 26 23:12:10 UTC 2025
@pnorman commented on this pull request.
> @@ -31,7 +31,7 @@ class SocialLink < ApplicationRecord
:flickr => %r{\Ahttps?://(?:www\.)?flickr\.com/people/([a-zA-Z0-9 at ._-]+)},
:github => %r{\Ahttps?://(?:www\.)?github\.com/([a-zA-Z0-9_-]+)},
:gitlab => %r{\Ahttps?://(?:www\.)?gitlab\.com/([a-zA-Z0-9_-]+)},
- :hdyc => %r{\Ahttps?://(?:www\.)?hdyc\.neis-one\.org/\?([a-zA-Z0-9_-]+)},
+ :hdyc => %r{\Ahttps?://(?:www\.)?hdyc\.neis-one\.org/\?([a-zA-Z0-9\s%20_-]+)},
> In that case, the changes made are valid right?
It would allow stuff like `%22`, `%_20`, and other invalid
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6468#discussion_r2464157273
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6468/review/3381483689 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20251026/1f3bda21/attachment.htm>
More information about the rails-dev
mailing list