[openstreetmap/openstreetmap-website] Language selection enhancements (PR #6412)
mmd
notifications at github.com
Wed Sep 24 17:49:58 UTC 2025
@mmd-osm commented on this pull request.
> - <% end %>
- <% else %>
- <%= render "layouts/select_language_list" %>
- <% end %>
+ <div class="mb-3 px-2">
+ <%= text_field_tag :language_search,
+ params[:language_search],
+ :placeholder => t("languages_panes.select_language_list.search_language", :default => "Search..."),
+ :autocomplete => "off",
+ :dir => "auto",
+ :class => "form-control py-2 px-3" %>
+ </div>
+ <turbo-frame id="select_language_list" src="<%= languages_pane_path %>?source=<%= ERB::Util.url_encode(request.fullpath) %>" loading="lazy">
+ <div class="text-center py-3">
+ <div class="spinner-border text-secondary" role="status">
+ <span class="visually-hidden">Loading...</span>
We have something similar in app/views/browse/_relation.html.erb. I think the text would be relevant for screen readers only, and it not visible otherwise.
<img width="852" height="138" alt="Image" src="https://github.com/user-attachments/assets/6bbc7e65-1d59-4524-a166-b297337df7db" />
<img width="829" height="265" alt="Image" src="https://github.com/user-attachments/assets/32bcaa22-8184-489b-a17a-a17b5dd07026" />
This pattern is following the example here: https://getbootstrap.com/docs/5.0/components/spinners/#border-spinner
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6412#discussion_r2376585826
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6412/review/3264019476 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250924/15314f63/attachment.htm>
More information about the rails-dev
mailing list