[openstreetmap/openstreetmap-website] Add geo URI handler registration on link interaction (PR #5968)

[Pablo Brasero]

@pablobm commented on this pull request.



> @@ -226,6 +228,16 @@ L.OSM.share = function (options) {
       const precision = 5 * Math.pow(10, Math.floor(Math.LOG10E * Math.log(scale)) - 2);
       return precision * Math.ceil(scale / precision);
     }
+
+    function askToHandleGeoURI() {
+      if (sessionStorage.getItem("wasAbleToAskForHandler")) return;
+      try {
+        navigator.registerProtocolHandler("geo", "/?geouri=%s");
+        sessionStorage.setItem("wasAbleToAskForHandler", "yes");
+      } catch (e) {
+        sessionStorage.setItem("wasAbleToAskForHandler", "no");

Why yes/no? I would have expected a simple boolean like `askedForHandler=true|false`. Are we expecting to use the "no" value at some point?

Also: should the key have a more specific name? Could there be other "handlers" in the future? I was thinking something like `askedForGeoProtocolHandler`.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5968#pullrequestreview-3273101633
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5968/review/3273101633 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20250926/a7482bfb/attachment.htm>