[openstreetmap/openstreetmap-website] Fix new Herb offenses (PR #6958)

Tom Hughes notifications at github.com
Thu Apr 2 11:29:12 UTC 2026


@tomhughes commented on this pull request.



> @@ -98,7 +98,7 @@ def check_trace_feed(traces)
             assert_select item, "guid", "http://www.example.com/user/#{ERB::Util.u(trace.user.display_name)}/traces/#{trace.id}"
             assert_select item, "description" do
               assert_dom_encoded do
-                assert_select "img[src='#{trace_icon_url trace.user, trace}']"
+                assert_select "img[src='#{trace_icon_path trace.user, trace}']"

I suspect it may have been deliberate that we used an absolute URL in the feed?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6958?email_source=notifications&email_token=AAK2OLKDZBFP5AVOCH4HMUT4TZFIRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBVGAYDKMRRG43KM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#pullrequestreview-4050052176
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6958/review/4050052176 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260402/54c80ad1/attachment.htm>


More information about the rails-dev mailing list