[openstreetmap/openstreetmap-website] Fix new Herb offenses (PR #6958)

Andy Allan notifications at github.com
Fri Apr 3 10:33:30 UTC 2026


@gravitystorm commented on this pull request.



> @@ -98,7 +98,7 @@ def check_trace_feed(traces)
             assert_select item, "guid", "http://www.example.com/user/#{ERB::Util.u(trace.user.display_name)}/traces/#{trace.id}"
             assert_select item, "description" do
               assert_dom_encoded do
-                assert_select "img[src='#{trace_icon_url trace.user, trace}']"
+                assert_select "img[src='#{trace_icon_path trace.user, trace}']"

Refs https://github.com/openstreetmap/openstreetmap-website/issues/1379 

Yes, urls used in rss `description` elements should be absolute urls and not relative urls. The original test is therefore correct.

See https://validator.w3.org/feed/docs/warning/ContainsRelRef.html

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6958?email_source=notifications&email_token=AAK2OLKEPTTLO2YYCVQW3YD4T6HPVA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBVGUZDAOJXGU22M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3032367828
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/6958/review/4055209755 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260403/8e139cea/attachment-0001.htm>


More information about the rails-dev mailing list