[openstreetmap/openstreetmap-website] Migrate `/export/embed.html` from leaflet to maplibre (PR #6804)
Frank Elsinga
notifications at github.com
Fri Apr 3 21:25:54 UTC 2026
@CommanderStorm commented on this pull request.
> + if (credit.href) {
+ const link = document.createElement("a");
+ link.href = credit.href;
+ link.textContent = text;
+
+ if (credit.donate) {
+ link.className = "donate-attr";
+ } else {
+ link.target = "_blank";
+ link.rel = "noopener noreferrer";
+ }
+
+ return link.outerHTML;
+ }
+
+ return text;
force pushed again, now with this change.
I really hate this rebasing and force pushing, this is such an confusing and error-prown workflow as can be seen here..
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6804?email_source=notifications&email_token=AAK2OLKENWCULXYWMS7FHU34UAT6FA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMBVG4ZTIOJWGIZ2M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3034444194
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6804/review/4057349623 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260403/e456d391/attachment-0001.htm>
More information about the rails-dev
mailing list