[openstreetmap/openstreetmap-website] Replace vendored leaflet.polyline plugin with @mapbox/polyline (PR #6996)
Tom Hughes
notifications at github.com
Mon Apr 13 18:00:07 UTC 2026
@tomhughes commented on this pull request.
> @@ -7,7 +7,7 @@
//= require leaflet.legend
//= require leaflet.note
//= require leaflet.share
-//= require leaflet.polyline
+//= require polyline_decoder
> > No I believe that it will only be included the first time it is seen.
>
> Are you sure? I think moving the require one level down would incldue JS multiple times.. If this were more than a stupid cpp style `#include`, why would this then happen?
>
> * [Don't reinitialise i18n in maplibre code #6630](https://github.com/openstreetmap/openstreetmap-website/pull/6630)
>
>
> Or am I misunderstanding what you mean?
That one was duplicated because it appeared in two different top level assets - in both `application.js` and a page specific file.
In this case we've talking about including it in multiple files are are included in `application.js` and in that case it will only appear once. I've just tested it to confirm.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/6996#discussion_r3074860885
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/6996/review/4100863008 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260413/209b6640/attachment-0001.htm>
More information about the rails-dev
mailing list