[openstreetmap/openstreetmap-website] On-site notifications (PR #7030)

[Pablo Brasero]

This is a partial implementation of on-site notifications, to gather some feedback before I get any deeper into it. At the moment, only one notification type is rendered: changeset comment notifications.

Notifications are listed in a dedicated page so that client apps (eg: JOSM) can easily link to them:

<img width="833" height="349" alt="notifications-first-stab" src="https://github.com/user-attachments/assets/919c32c1-b05e-4335-aac1-9a74656637a9" />

Out of scope for this PR:
- Marking notifications as seen/read. That's its own can of design worms. Let's leave it for a separate PR.
- Similarly, any indication (number, red dot, etc) that there are unseen/unread notifications.

What I'm missing in this PR:
- All other notification types. Also there are some pending merge (https://github.com/openstreetmap/openstreetmap-website/pull/6939) but they can come in a later PR if they don't land before this.
- Considering all the n+1 queries that are going to result in this page.
- Pagination.

Thoughts on this approach? Should I carry on and complete it?
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/7030?email_source=notifications&email_token=AAK2OLJVTZPEKTHVHS7VCJD4XI665A5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTKNZUGMZDMMBQG6THEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVVYHEX3POBSW4X3DNRUWG2Y

-- Commit Summary --

  * Create page to list notifications
  * List changeset comment notifications

-- File Changes --

    M .rubocop_todo.yml (2)
    M app/abilities/ability.rb (1)
    A app/controllers/notifications_controller.rb (16)
    M app/models/user.rb (2)
    A app/models/user_notifications.rb (74)
    M app/views/layouts/_header.html.erb (1)
    A app/views/notifications/_changeset_comment.html.erb (26)
    A app/views/notifications/index.html.erb (7)
    M config/locales/en.yml (7)
    M config/routes.rb (2)
    A test/controllers/notifications/changeset_comment_view_test.rb (27)
    A test/controllers/notifications_controller_test.rb (19)
    A test/factories/notifications.rb (12)
    A test/models/user_notifications_test.rb (21)
    A test/system/onsite_notifications_test.rb (33)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/7030.patch?email_source=notifications&email_token=AAK2OLMUE3KLE7SQAUDDEBL4XI665A5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTKNZUGMZDMMBQG6THEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVZYHEX3QMF2GG2C7MNWGSY3Lhttps://github.com/openstreetmap/openstreetmap-website/pull/7030.diff?email_source=notifications&email_token=AAK2OLOB7EEQP4RBDVR773T4XI665A5CNFSNUABEM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UF4ZTKNZUGMZDMMBQG6THEZLBONXW5KTTOVRHGY3SNFRGKZFFMV3GK3TUVVYHEX3ENFTGMX3DNRUWG2Y
-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7030
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7030 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260423/b6d164a0/attachment-0001.htm>