[openstreetmap/openstreetmap-website] On-site notifications (PR #7030)

[Pablo Brasero]

@pablobm commented on this pull request.



> +    <%= t(
+          ".notification_header_html",
+          :changeset_comment_link => link_to(
+            t(".changeset_comment"),
+            changeset_path(
+              notification.changeset,
+              :anchor => "c#{notification.comment_id}"
+            )
+          ),
+          :commenter_name_link => link_to(
+            notification.commenter.display_name,
+            notification.commenter
+          ),
+          :time_ago => friendly_date_ago(notification.timestamp)
+        ) %>

Sharing content with the emails, including the subject line, makes a lot of sense; I'll play a bit with the idea. Sharing code between the two might be tricky but at worst we can accept it as incidental duplication and that's fine.

As for sharing code across notifications, let's see where this goes. This line in particular looks difficult to factor out to me, as each translation line will have different names and fiddly details, but who knows.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/7030?email_source=notifications&email_token=AAK2OLMJJ5PSBHVMS5P55N34XLZK7A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMJWG44TQOJQGE32M4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOS6XA4S7OJSXM2LFO5PW433UNFTGSY3BORUW63TTL5RWY2LDNM#discussion_r3135574745
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/7030/review/4167989017 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20260423/2e34fd68/attachment.htm>